chore: add logical-assignment-operators#7409
chore: add logical-assignment-operators#7409CommanderStorm wants to merge 7 commits intomaplibre:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7409 +/- ##
==========================================
- Coverage 92.77% 92.52% -0.26%
==========================================
Files 289 289
Lines 24021 23989 -32
Branches 5100 5091 -9
==========================================
- Hits 22286 22196 -90
- Misses 1735 1793 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (this.imageAtlas) { | ||
| this.imageAtlas = null; | ||
| } | ||
| this.imageAtlas &&= null; |
There was a problem hiding this comment.
Just = null without the if or &&?
There was a problem hiding this comment.
this is not a code change
| if (this.dashPositions) { | ||
| this.dashPositions = null; | ||
| } | ||
| this.dashPositions &&= null; |
There was a problem hiding this comment.
this is not a code change
| if (this._frameId) { | ||
| this._frameId = null; | ||
| } | ||
| this._frameId &&= null; |
There was a problem hiding this comment.
Maybe better to set it to false as this is a boolean, or even change its name to indicate it's not holding an id.
There was a problem hiding this comment.
this is not a code change. Lets stick to the previous logic.
|
Thanks! Done my review, looks good overall, added a few comments. |
|
it is very hard to do lints against a moving target. can we +1 instead of bike shedding on the small stuff please? |
2 participants
simplifies the code, but won't make it shorter until #7404
logical assigment is es2021